Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support riscv64 with p2.inf #1485

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Add support riscv64 with p2.inf #1485

merged 1 commit into from
Sep 29, 2024
+10 −0

Conversation

yuzibo
Copy link
Contributor

@yuzibo yuzibo commented Sep 24, 2024

This can be enable after riscv64 fragment built by default

@yuzibo yuzibo force-pushed the enable-build-on-riscv64-of-p2 branch from 93e8dd2 to 406517b Compare September 24, 2024 00:43
@yuzibo yuzibo changed the title Add support riscv64 with p2.inf [draft] Add support riscv64 with p2.inf Sep 24, 2024
@yuzibo yuzibo mentioned this pull request Sep 24, 2024
Closed
33 tasks
@yuzibo
Copy link
Contributor Author

yuzibo commented Sep 24, 2024

See comment

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

Test Results

   486 files  ±0     486 suites  ±0   8m 31s ⏱️ -33s
 4 159 tests ±0   4 151 ✅ ±0   8 💤 ±0  0 ❌ ±0 
16 390 runs  ±0  16 298 ✅ ±0  92 💤 ±0  0 ❌ ±0 

Results for commit 90e0c60. ± Comparison against base commit 8c39dcd.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell self-requested a review September 24, 2024 05:59
@yuzibo yuzibo force-pushed the enable-build-on-riscv64-of-p2 branch from 406517b to 7ac736b Compare September 26, 2024 15:59
@yuzibo yuzibo changed the title [draft] Add support riscv64 with p2.inf Add support riscv64 with p2.inf Sep 26, 2024
@yuzibo
Copy link
Contributor Author

yuzibo commented Sep 26, 2024

Can we merge the PR now?

@yuzibo
Copy link
Contributor Author

yuzibo commented Sep 26, 2024

Can we merge the PR now?

In fact, I mean the PR does not block to build Eclipse on riscv64(maybe), but we are blocked by other errors. Building this again to see the reslut.

@HannesWell
Copy link
Member

Can we merge the PR now?

In fact, I mean the PR does not block to build Eclipse on riscv64(maybe), but we are blocked by other errors. Building this again to see the reslut.

This can be merged as soon as eclipse-platform/eclipse.platform.releng.aggregator#2394 is submitted.
Only with both changes the SWT (and Equinox) native artifacts end up in the p2 repository and can be fetched by builds for other repositories, which would fail if only this is submitted.

@yuzibo @HannesWell
Add support riscv64 with p2.inf
90e0c60 
This can be enable after riscv64 fragment built by default

Signed-off-by: Bo YU <[email protected]>
@HannesWell HannesWell force-pushed the enable-build-on-riscv64-of-p2 branch from 7ac736b to 90e0c60 Compare September 29, 2024 11:23
HannesWell
HannesWell approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thank you.

Now that eclipse-platform/eclipse.platform.releng.aggregator#2394 is about to be submitted, this can be submitted too.

@HannesWell HannesWell merged commit 03408d8 into eclipse-platform:master Sep 29, 2024
14 checks passed
@yuzibo yuzibo deleted the enable-build-on-riscv64-of-p2 branch September 29, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HannesWell HannesWell HannesWell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuzibo @HannesWell